Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text with leading whitespace parsing #1015

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Fix text with leading whitespace parsing #1015

merged 6 commits into from
Apr 18, 2024

Conversation

styrix560
Copy link
Collaborator

Closes: #896

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@jwbot jwbot enabled auto-merge April 13, 2024 19:54
@jwbot jwbot added P: Compiler: Frontend Package: The compiler frontend P: Compiler: VM Package: The VM executing Candy byte code (LIR) labels Apr 13, 2024
@jwbot
Copy link
Collaborator

jwbot commented Apr 13, 2024

🐰Bencher

ReportSun, April 14, 2024 at 15:16:08 UTC
ProjectCandy
Branchfix_leading_whitespace
TestbedGitHub Actions: Ubuntu 22.04
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles
InstructionsInstructions Results
instructions
L1 AccessesL1 Accesses Results
accesses
L2 AccessesL2 Accesses Results
accesses
RAM AccessesRAM Accesses Results
accesses
Total AccessesTotal Accesses Results
total-accesses
compile: Examples/fibonacci.candy ➖ (view plot)1792863946.000➖ (view plot)1189832646.000➖ (view plot)1619868841.000➖ (view plot)10919113.000➖ (view plot)3382844.000➖ (view plot)1634170798.000
compile: Examples/helloWorld.candy ➖ (view plot)284258631.000➖ (view plot)176154193.000➖ (view plot)248006081.000➖ (view plot)1503972.000➖ (view plot)820934.000➖ (view plot)250330987.000
vm_runtime: Examples/fibonacci.candy 10➖ (view plot)184018102.000➖ (view plot)107475386.000➖ (view plot)151427342.000➖ (view plot)897341.000➖ (view plot)802973.000➖ (view plot)153127656.000
vm_runtime: Examples/helloWorld.candy ➖ (view plot)154519837.000➖ (view plot)88650886.000➖ (view plot)124980262.000➖ (view plot)697031.000➖ (view plot)744412.000➖ (view plot)126421705.000

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

compiler/vm/src/heap/mod.rs Outdated Show resolved Hide resolved
compiler/frontend/src/string_to_rcst/text.rs Show resolved Hide resolved
compiler/frontend/src/string_to_rcst/text.rs Outdated Show resolved Hide resolved
@styrix560
Copy link
Collaborator Author

I messed up with the merge. I will fix this and request another review

@jwbot jwbot merged commit 0766057 into main Apr 18, 2024
11 checks passed
@jwbot jwbot deleted the fix_leading_whitespace branch April 18, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: Compiler: Frontend Package: The compiler frontend P: Compiler: VM Package: The VM executing Candy byte code (LIR)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Text literal is missing whitespace after opening quote
3 participants